[ovs-dev] [PATCH] ofproto-dpif: APIs and CLI option to add/delete static fdb entry

0-day Robot robot at bytheb.org
Sat May 8 12:12:03 UTC 2021


Bleep bloop.  Greetings Vasu Dasari, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#118 FILE: ofproto/ofproto-dpif-xlate.c:8015:
xlate_add_static_mac_entry(const struct ofproto_dpif *ofproto, ofp_port_t in_port,

WARNING: Line is 80 characters long (recommended limit is 79)
#153 FILE: ofproto/ofproto-dpif-xlate.h:228:
void xlate_add_static_mac_entry(const struct ofproto_dpif *, ofp_port_t in_port,

ERROR: Inappropriate spacing around cast
#176 FILE: ofproto/ofproto-dpif.c:5875:
    const char *op = (const char *)aux;

WARNING: Line is 97 characters long (recommended limit is 79)
#193 FILE: ofproto/ofproto-dpif.c:5892:
        unixctl_command_reply_error(conn, "software error, odp port is present but no ofp port");

Lines checked: 277, Warnings: 3, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list