[ovs-dev] [PATCH dpdk-latest 1/6] travis: Switch to dpdk main branch.

Stokes, Ian ian.stokes at intel.com
Wed May 12 10:28:13 UTC 2021


> On 06/05/2021 16:25, David Marchand wrote:
> > Make this branch point to current main master branch so that we can
> > track API breakage.
> >
> 
> s/master//

I can strip out master above and keep it as main on commit.
 
> 
> > Note: this should not be merged to master, intended for dpdk-latest
> > branch only.
> >
> 
> It's probably better to give full project/branch names when branches
> from dpdk and ovs are referred to in the commit log. e.g. "dpdk main
> branch". It would get confusing for someone not familiar.

Agreed, can make this change on commit.

> 
> > Signed-off-by: David Marchand <david.marchand at redhat.com>
> > Acked-by: Ilya Maximets <i.maximets at ovn.org>
> > Signed-off-by: Ian Stokes <ian.stokes at intel.com>
> >
> > The default branch name in DPDK is changed from master to main.
> > This patch reflects the same on travis builds for dpdk-latest branch.
> >
> > Tested-at: https://travis-ci.org/github/Sunil-Pai-G/ovs-
> copy/builds/723223426
> 
> "We couldn't display the repository Sunil-Pai-G/ovs-copy".

Yes looks like this isn't available anymore, also this points to travis-ci.org, this is set to be removed completely in a few weeks and changed to travis-ci.com.

As such it probably doesn't make sense to have the tested by tag above as is. As this will never be in an release we could just remove it, otherwise wait for a new tag from travis-ci.com.

As the change is small I thinks its ok to remove? Thoughts?

> 
> > Signed-off-by: Sunil Pai G <sunil.pai.g at intel.com>
> > Signed-off-by: Ian Stokes <ian.stokes at intel.com>
> 
> It's a very small patch to be squashed patches with multiple signoffs?
> Ignore comment if commit log makes sense, but checkpatch is complaining
> too.
> 
> WARNING: Unexpected sign-offs from developers who are not authors or
> co-authors or committers: Ian Stokes <ian.stokes at intel.com>, Sunil Pai G
> <sunil.pai.g at intel.com>, Ian Stokes <ian.stokes at intel.com>
> Lines checked: 36, Warnings: 1, Errors: 0

I think it's minor, can add a co-author and sign off for Sunil here to avoid the error? As David has done the rebase maybe that’s the correct approach?


BR 
Ian
> 
> > ---
> >  .travis.yml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index 51d0511080..7e87360256 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -30,7 +30,9 @@ addons:
> >
> >  before_install: ./.ci/${TRAVIS_OS_NAME}-prepare.sh
> >
> > -before_script: export PATH=$PATH:$HOME/bin
> > +before_script:
> > +  - export PATH=$PATH:$HOME/bin
> > +  - export DPDK_VER=refs/heads/main
> >
> >  matrix:
> >    include:
> >



More information about the dev mailing list