[ovs-dev] [PATCH v2 1/2] add port-based ingress policing based packet-per-second rate-limiting

0-day Robot robot at bytheb.org
Mon May 17 11:59:07 UTC 2021


Bleep bloop.  Greetings Simon Horman, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Simon Horman <simon.horman at netronome.com>, Baowen Zheng <baowen.zheng at corigine.com>, Louis Peens <louis.peens at netronome.com>
WARNING: Line is 92 characters long (recommended limit is 79)
#191 FILE: lib/netdev-linux.c:2630:
                                                MIN(UINT32_MAX / 1024, kpkts_burst) * 1024);

ERROR: Inappropriate spacing around cast
#192 FILE: lib/netdev-linux.c:2631:
            nl_msg_put_u64(request, TCA_POLICE_PKTRATE64, (uint64_t)pps_rate);

WARNING: Line is 86 characters long (recommended limit is 79)
ERROR: Inappropriate spacing around cast
#193 FILE: lib/netdev-linux.c:2632:
            nl_msg_put_u64(request, TCA_POLICE_PKTBURST64, (uint64_t)pkt_burst_ticks);

WARNING: Line is 83 characters long (recommended limit is 79)
#304 FILE: lib/netdev-linux.c:5569:
 * of 'kbits_burst', with a rate of 'kpkts_rate' and a burst size of 'kpkts_burst'.

WARNING: Line is 81 characters long (recommended limit is 79)
#429 FILE: vswitchd/bridge.c:4900:
                        MIN(UINT32_MAX, iface->cfg->ingress_policing_kpkts_rate),

WARNING: Line is 83 characters long (recommended limit is 79)
#430 FILE: vswitchd/bridge.c:4901:
                        MIN(UINT32_MAX, iface->cfg->ingress_policing_kpkts_burst));

Lines checked: 554, Warnings: 6, Errors: 2


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list