[ovs-dev] [PATCH] dpif-netdev: Reset RxQ cycles history on PMD reload.
grive at u256.net
Mon Nov 1 23:32:47 UTC 2021
On Wed, Oct 20, 2021, at 11:04, Kevin Traynor wrote:
> When a PMD reload occurs, some PMD cycle measurements are reset.
> In order to preserve the full cycles history of an Rxq, the RxQ
> cycle measurements were not reset.
> These are both used together to display the % of a PMD that an
> RxQ is using in the pmd-rxq-show stat.
> Resetting one and not the other can lead to some unintuitive
> looking stats while the stats settle for the new config. In
> some cases, it may appear like the RxQs are using >100% of a PMD.
> This resolves when the stats settle for the new config, but
> seeing RxQs apparently using >100% of a PMD may confuse a user
> and lead them to think there is a bug.
> To avoid this, reset the RxQ cycle measurements on PMD reload.
> Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Change seems reasonable,
Acked-by: Gaetan Rivet <grive at u256.net>
More information about the dev