[ovs-dev] [PATCH v2] jsonrpc: Sort JSON objects only if debug is on

Mike Pattrick mkp at redhat.com
Tue Nov 2 15:56:56 UTC 2021


Hi Anton,

Anton Ivanov <anton.ivanov at cambridgegreys.com> writes:

> From: Anton Ivanov <anton.ivanov at cambridgegreys.com>
> 
> There is no point to sort JSON objects when nobody is
> observing them. Machines do not care if it is sorted or
> not.
> 
> Signed-off-by: Anton Ivanov <anton.ivanov at cambridgegreys.com>

This makes sense to me. The automated CI seems to have had 
an issue when this was submitted, but it does pass the
tests.

I see previously there was a discussion about how this
might affect human readability, but I think the ability
to pipe unsorted JSON into command line prettifiers like
"python -m json.tool" should cover most manual inspection
use cases.

Acked-by: Mike Pattrick <mkp at redhat.com>



More information about the dev mailing list