[ovs-dev] [PATCH ovn] ci: Don't run unit tests for system-test job.

Dumitru Ceara dceara at redhat.com
Wed Nov 3 16:50:50 UTC 2021


On 11/3/21 5:39 PM, Numan Siddique wrote:
> On Wed, Nov 3, 2021 at 12:09 PM Ilya Maximets <i.maximets at ovn.org> wrote:
>>
>> On 11/3/21 17:01, numans at ovn.org wrote:
>>> From: Numan Siddique <numans at ovn.org>
>>>
>>> For the system-test matrix, running unit tests is not
>>> required and if a unit test fails, then system tests
>>> are not run.  Also test matrix covers unit tests anyway.
>>
>> Hmm.  I don't think that is correct.
>> IIUC, the only remaining gcc unit test run is with jemalloc.
>> The one within a system-test job is the only normal test run
>> we have.
> 
> Thanks for pointing this out.  I missed it.
> 
> I'll add another test matrix to run unit tests with gcc.
> The main reason for this patch is to run system tests even if unit
> tests fail (either due to a flake or due to genuine failure).

+1 for this.

In the patch that originally enabled system tests in CI the goal was to
save some CI time/resources but indeed the flakiness of the unit tests
makes it more reliable to have a separate test matrix entry for system
tests.

Regards,
Dumitru



More information about the dev mailing list