[ovs-dev] [PATCH ovn v1 3/5] ovn-detrace: rename ovn-detrace to ovn_detrace.py

Dumitru Ceara dceara at redhat.com
Fri Nov 5 16:12:27 UTC 2021


On 10/21/21 11:10 AM, Adrian Moreno wrote:
> For external python programs to be able to load ovn-detrace as a python
> module easily, it should end in .py and should have underscores.
> 
> Move ovn-detrace to ovn_detrace.py and create a symlink with the old name
> for backwards compatibility.
> 
> Signed-off-by: Adrian Moreno <amorenoz at redhat.com>
> ---
>  debian/ovn-common.install                       |  2 +-
>  debian/ovn-common.postinst                      |  1 +
>  debian/ovn-common.postrm                        |  1 +

I don't know about the debian parts.

>  rhel/ovn-fedora.spec.in                         |  3 +++
>  utilities/.gitignore                            |  2 +-
>  utilities/automake.mk                           | 14 ++++++++++++--
>  utilities/{ovn-detrace.in => ovn_detrace.py.in} |  0
>  7 files changed, 19 insertions(+), 4 deletions(-)
>  rename utilities/{ovn-detrace.in => ovn_detrace.py.in} (100%)

But the rest looks good to me:

Acked-by: Dumitru Ceara <dceara at redhat.com>



More information about the dev mailing list