[ovs-dev] [PATCH ovn v2] ci: Don't run unit tests for system-test job.

Dumitru Ceara dceara at redhat.com
Mon Nov 8 15:42:57 UTC 2021


On 11/3/21 5:55 PM, numans at ovn.org wrote:
> From: Numan Siddique <numans at ovn.org>
> 
> system-test matrix first runs unit tests and then system tests.
> And if unit tests fail, system tests are not run.
> 
> This patch now runs only system tests for system-test matrix.
> A new entry is added in the test matrix - 'gcc compiler with
> unit tests'.
> 
> Signed-off-by: Numan Siddique <numans at ovn.org>
> ---

Hi Numan,

> 
> v1 -> v2
> ----
>  * Addressed Ilya's comments.
> 
>  .ci/linux-build.sh         | 22 +++++++++++-----------
>  .github/workflows/test.yml |  2 ++
>  2 files changed, 13 insertions(+), 11 deletions(-)
> 
> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> index 76a2ff459f..b0975685d4 100755
> --- a/.ci/linux-build.sh
> +++ b/.ci/linux-build.sh
> @@ -49,17 +49,6 @@ else
>  fi
>  
>  if [ "$TESTSUITE" ]; then
> -    # 'distcheck' will reconfigure with required options.
> -    # Now we only need to prepare the Makefile without sparse-wrapped CC.
> -    configure_ovn
> -
> -    export DISTCHECK_CONFIGURE_FLAGS="$OPTS"
> -    if ! make distcheck -j4 TESTSUITEFLAGS="-j4" RECHECK=yes; then
> -        # testsuite.log is necessary for debugging.
> -        cat */_build/sub/tests/testsuite.log
> -        exit 1
> -    fi
> -
>      if [ "$TESTSUITE" = "system-test" ]; then
>          # Reconfigure build with required OPTS, rebuild and run system tests.

We're not really reconfiguring/rebuilding anymore, this can probably be
updated to:

# Configure build with required OPTS, build and run system tests.

Or, even better, the comment can be removed altogether; but I guess this
can be fixed up at apply time, therefore:

Acked-by: Dumitru Ceara <dceara at redhat.com>

Thanks,
Dumitru



More information about the dev mailing list