[ovs-dev] [PATCH v6 1/2] dpctl: dpif: add kernel datapath cache hit output

Ilya Maximets i.maximets at ovn.org
Mon Nov 8 21:37:29 UTC 2021


On 11/5/21 10:20, Eelco Chaudron wrote:
> 
> 
> On 4 Nov 2021, at 15:51, Ilya Maximets wrote:
> 
>> Hi, Eelco.  Sorry for this taking so long.
>>
>> The patch looks good to me, just one small nit below.
>>
>> On 9/6/21 10:53, Eelco Chaudron wrote:
>>> This patch adds cache usage statistics to the output:
>>>
>>> $ ovs-dpctl show
>>> system at ovs-system:
>>>   lookups: hit:24 missed:71 lost:0
>>>   flows: 0
>>>   masks: hit:334 total:0 hit/pkt:3.52
>>>   cache: hit:4 hit rate:4.21%
>>
>> The space in "hit rate" doesn't look right.   All the other things
>> are written as a single word followed by a semicolon and a number,
>> so maybe this should be a single word too.  E.g.:
>>
>>    cache: hit:4 hit-rate:4.21%
>>
>> What do you think?   I can make this change before applying a patch.
> 
> The change looks fine! Please make the change before applying.
> 
> Thanks,
> 
> Eelco
> 
>> Best regards, Ilya Maximets.
>>
>>>   port 0: ovs-system (internal)
>>>   port 1: genev_sys_6081 (geneve: packet_type=ptap)
>>>   port 2: br-int (internal)
>>>   port 3: br-ex (internal)
>>>   port 4: eth2
>>>   port 5: sw1p1 (internal)
>>>   port 6: sw0p4 (internal)
> 

Thanks!  Applied.

Best regards, Ilya Maximets.


More information about the dev mailing list