[ovs-dev] [PATCH v2] ofproto/bond: Improve admissibility debug readability.

Ilya Maximets i.maximets at ovn.org
Tue Nov 16 14:19:44 UTC 2021


On 10/15/21 16:30, David Marchand wrote:
> The admissibility check currently log a message like (line wrapped in
> this commitlog):
> bond(revalidator11)|DBG|member (dpdk0): Admissibility
> verdict is to drop pkt as different port is learned.active member: false,
> may_enable: true enable: true LACP status:2
> 
> Fix spaces around the period character and separate debug infos with
> commas.
> Prefix all log messages in this check with bond and member names.
> Display a human readable string for LACP status.
> 
> New logs look like:
> bond(revalidator11)|DBG|bond dpdkbond0: member dpdk0: admissibility
> verdict is to drop pkt as different port is learned, active member: false,
> may_enable: true, enabled: true, LACP status: off
> 
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> Acked-by: Kevin Traynor <ktraynor at redhat.com>
> ---
> Changes since v1:
> - s/enable/enabled/ in log for consistency,
> 
> ---

Thanks, David and Kevin!  Applied.

Best regards, Ilya Maximets.


More information about the dev mailing list