[ovs-dev] [PATCH] netdev-vport: Fix compilation warning

Roi Dayan roid at nvidia.com
Wed Nov 17 12:11:42 UTC 2021


port is declared as uint16 so use %hu specifier instead of %d.

lib/netdev-vport.c:460:44: error: '%s' directive output may be truncated writing up to 4 bytes into a region of size between 1 and 10 [-Werror=format-truncation=]
      snprintf(namebuf, bufsize, "dst_port_%d%s",
                                           ^~
Fixes: 189de33f02b2 ("netdev-vport: reject concomitant incompatible tunnels")
Signed-off-by: Roi Dayan <roid at nvidia.com>
Reviewed-by: Eli Britstein <elibr at nvidia.com>
---
 lib/netdev-vport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
index 499c0291c933..1c7f55757e9a 100644
--- a/lib/netdev-vport.c
+++ b/lib/netdev-vport.c
@@ -457,7 +457,7 @@ static char *
 vxlan_get_port_ext_gbp_str(uint16_t port, bool gbp,
                            char namebuf[], size_t bufsize)
 {
-    snprintf(namebuf, bufsize, "dst_port_%d%s",
+    snprintf(namebuf, bufsize, "dst_port_%hu%s",
              port, gbp ? "_gbp" : "");
 
     return namebuf;
-- 
2.8.0



More information about the dev mailing list