[ovs-dev] [PATCH v2] checkpatch: Detect "trojan source" attack

Aaron Conole aconole at redhat.com
Wed Nov 17 16:58:19 UTC 2021

Mike Pattrick <mkp at redhat.com> writes:

> Recently there has been a lot of press about the "trojan source" attack,
> where Unicode characters are used to obfuscate the true functionality of
> code. This attack didn't effect OVS, but adding the check here will help
> guard against it sneaking in later.
> Signed-off-by: Mike Pattrick <mkp at redhat.com>
> ---
> Changes in v2:
>    - Now all unicode characters will result in an error.
> ---

I was going to suggest a checkpatch test for this - but that might
result in the patch triggering itself with an error (because the robot
uses the submitted version of checkpatch.py when testing).

WDYT, Ilya, Gaëtan?

In either case:

Acked-by: Aaron Conole <aconole at redhat.com>

More information about the dev mailing list