[ovs-dev] [PATCH ovn] northd: I-P add explicit dependency on Load_Balancer_Group.

Numan Siddique numans at ovn.org
Tue Nov 23 02:32:32 UTC 2021


On Fri, Nov 19, 2021 at 6:43 AM Dumitru Ceara <dceara at redhat.com> wrote:
>
> The commit that added I-P for northd missed to add this explicit
> dependency.  This didn't really affect functionality because:
> a. ovn-northd monitors the whole NB database
> b. changes to the Load_Balancer_Group table mark rows in Logical_Switch
>    table that refer to the updated LB groups as "updated".
>
> However, it's probably better to make this dependency explicit having in
> mind that real incremental processing might be implemented in the
> future.
>
> Fixes: 4597317f16d1 ("northd: Introduce incremental processing for northd")
> Signed-off-by: Dumitru Ceara <dceara at redhat.com>

Thanks.  I applied this patch to the main branch.

Numan

> ---
>  northd/inc-proc-northd.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/northd/inc-proc-northd.c b/northd/inc-proc-northd.c
> index c7f49d599..8e7428dda 100644
> --- a/northd/inc-proc-northd.c
> +++ b/northd/inc-proc-northd.c
> @@ -42,6 +42,7 @@ VLOG_DEFINE_THIS_MODULE(inc_proc_northd);
>      NB_NODE(address_set, "address_set") \
>      NB_NODE(port_group, "port_group") \
>      NB_NODE(load_balancer, "load_balancer") \
> +    NB_NODE(load_balancer_group, "load_balancer_group") \
>      NB_NODE(load_balancer_health_check, "load_balancer_health_check") \
>      NB_NODE(acl, "acl") \
>      NB_NODE(logical_router, "logical_router") \
> @@ -159,6 +160,7 @@ void inc_proc_northd_init(struct ovsdb_idl_loop *nb,
>      engine_add_input(&en_northd, &en_nb_address_set, NULL);
>      engine_add_input(&en_northd, &en_nb_port_group, NULL);
>      engine_add_input(&en_northd, &en_nb_load_balancer, NULL);
> +    engine_add_input(&en_northd, &en_nb_load_balancer_group, NULL);
>      engine_add_input(&en_northd, &en_nb_load_balancer_health_check, NULL);
>      engine_add_input(&en_northd, &en_nb_acl, NULL);
>      engine_add_input(&en_northd, &en_nb_logical_router, NULL);
> --
> 2.27.0
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list