[ovs-dev] [PATCH ovn 2/2] tests: fix flaky VXLAN check port/datapath key space limits test

Vladislav Odintsov odivlad at gmail.com
Tue Nov 23 17:07:39 UTC 2021

OVN requested-tnl-key VXLAN checks affect tunnel_key in
datapath_binding record only on datapath tunnel key assigning.
If a dp tnl key was already assigned and VXLAN-enabled chassis
is added after that, the value would never be changed.

The test didn't check the VXLAN-enabled chassis was created and
thus test could fail like this:

ovn.at:3777: waiting until test x`ovn-nbctl lsp-get-up lsp-bad` = xup...
ovn.at:3777: wait succeeded immediately
./ovn.at:3777: ovn-sbctl get Datapath_Binding ls-bad tunnel_key
--- -	2021-11-23 17:34:51.646403185 +0300
+++ /builddir/build/BUILD/ovn-21.09.90/tests/testsuite.dir/at-groups/104/stdout	2021-11-23 17:34:51.644406189 +0300
@@ -1,2 +1,2 @@

This patch fixes such fail by adding await for chassis to be
registered in SB DB.

Signed-off-by: Vladislav Odintsov <odivlad at gmail.com>
 tests/ovn.at | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/ovn.at b/tests/ovn.at
index 965eed809..c39f3162e 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -3783,6 +3783,7 @@ check ovs-vsctl add-br br-phys
 check ovs-vsctl set open . external-ids:ovn-bridge-mappings=phys:br-phys
 ovn_attach net br-phys 24 vxlan
 check ovn-nbctl --wait=sb sync
+OVS_WAIT_UNTIL([ovn-sbctl get chassis main _uuid])
 check ovn-nbctl ls-add ls-bad -- \
     set Logical_Switch ls-bad other_config:requested-tnl-key=5000

More information about the dev mailing list