[ovs-dev] [PATCH] tests/flowgen: Fix length field of 802.2 data link header.

Paolo Valerio pvalerio at redhat.com
Wed Nov 24 18:32:36 UTC 2021

Hello Ilya,

Ilya Maximets <i.maximets at ovn.org> writes:

> Length in Data Link Header for these packets should not include
> source and destination MACs or the length field itself.
> Therefore, it should be 14 bytes less, otherwise other network
> tools like wireshark complains:
>   Expert Info (Error/Malformed):
>     Length field value goes past the end of the payload
> Additionally fixing the printing of the packet/flow configuration,
> as it currently prints '%s=%s' strings without any real data.
> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
> ---

The patch LGTM and works as expected.
Do you think it makes sense to include a 'Fixes' tag?

In any case:

Acked-by: Paolo Valerio <pvalerio at redhat.com>

More information about the dev mailing list