[ovs-dev] [PATCH 2/2] ovsdb-data: Consolidate ovsdb atom and json strings.

Dumitru Ceara dceara at redhat.com
Mon Nov 29 15:47:58 UTC 2021

On 11/22/21 01:09, Ilya Maximets wrote:
> ovsdb_atom_string and json_string are basically the same data structure
> and ovsdb-server frequently needs to convert one to another.  We can
> avoid that by using json_string from the beginning for all ovsdb
> strings.  So, the conversion turns into simple json_clone(), i.e.
> increment of a reference counter.  This change doesn't give any
> significant performance boost, but it improves the code clarity and
> may be useful for future development.
> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
> ---

I'm assuming this also doesn't cause a visible performance hit because
of extra, non-inlined, calls to json_string(), right?  Then:

Acked-by: Dumitru Ceara <dceara at redhat.com>


More information about the dev mailing list