[ovs-dev] [PATCH ovn] northd: remove leftover references to l3redirect_port

Numan Siddique numans at ovn.org
Mon Nov 29 21:52:42 UTC 2021


On Fri, Nov 26, 2021 at 5:41 PM James Troup <james.troup at canonical.com> wrote:
>
> l3redirect_port was removed in 15348b7b8; remove references to it from
> comments.
>
> There is a comment in build_gateway_redirect_flows_for_lrouter() that
> supersedes the one removed below.
>
> Signed-off-by: James Troup <james.troup at canonical.com>

Thanks for the patch.  I applied to the main branch.

Numan

> ---
>  northd/northd.c |   11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/northd/northd.c b/northd/northd.c
> index cf2467fe1..517beea01 100644
> --- a/northd/northd.c
> +++ b/northd/northd.c
> @@ -589,8 +589,7 @@ struct ovn_datapath {
>
>      /* Applies to only logical router datapath.
>       * True if logical router is a gateway router. i.e options:chassis is set.
> -     * If this is true, then 'l3dgw_port' and 'l3redirect_port' will be
> -     * ignored. */
> +     * If this is true, then 'l3dgw_port' will be ignored. */
>      bool is_gw_router;
>
>      /* OVN northd only needs to know about the logical router gateway port for
> @@ -11360,13 +11359,7 @@ build_check_pkt_len_flows_for_lrouter(
>      }
>  }
>
> -/* Logical router ingress table GW_REDIRECT: Gateway redirect.
> - *
> - * For traffic with outport equal to the l3dgw_port
> - * on a distributed router, this table redirects a subset
> - * of the traffic to the l3redirect_port which represents
> - * the central instance of the l3dgw_port.
> - */
> +/* Logical router ingress table GW_REDIRECT: Gateway redirect. */
>  static void
>  build_gateway_redirect_flows_for_lrouter(
>          struct ovn_datapath *od, struct hmap *lflows,
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list