[ovs-dev] [PATCH ovn] controller: Add IDL memory reports.

Numan Siddique numans at ovn.org
Mon Nov 29 22:21:25 UTC 2021


On Tue, Nov 23, 2021 at 10:02 AM Dumitru Ceara <dceara at redhat.com> wrote:
>
> OVS commit 066741d9c5ca ("ovsdb-idl: Add memory report function.")
> enhanced the IDL to track memory usage.  Use it in ovn-controller for
> the Southbound DB and local OVS DB IDLs.
>
> Signed-off-by: Dumitru Ceara <dceara at redhat.com>
> ---
>  controller/ovn-controller.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c
> index 29c1a05b2..fa1ff13bd 100644
> --- a/controller/ovn-controller.c
> +++ b/controller/ovn-controller.c
> @@ -3444,6 +3444,8 @@ main(int argc, char *argv[])
>              ofctrl_get_memory_usage(&usage);
>              if_status_mgr_get_memory_usage(if_mgr, &usage);
>              local_datapath_memory_usage(&usage);
> +            ovsdb_idl_get_memory_usage(ovnsb_idl_loop.idl, &usage);
> +            ovsdb_idl_get_memory_usage(ovs_idl_loop.idl, &usage);

Thanks for the patch.  I've one question.

The function ovsdb_idl_get_memory_usage() adds 2 items to the "usage"
simap - "idl-cells" and "idl-outstanding-txns" (if its value is
greater than zero).
After the ovsdb_idl_get_memory_usage() for OVS IDL is called, the
"idl-cells" value in usage will be the sum of SB IDL cells and OVS IDL
cells.
That's intentional right ?  I think it makes sense.  Just wanted to
check with you.
Is there a value in reporting as - "sb-idl-cells=<n>", ovs-idl-cells=<p>.."  ?


Thanks
Numan


>              memory_report(&usage);
>              simap_destroy(&usage);
>          }
> --
> 2.27.0
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list