[ovs-dev] [PATCH dpdk-latest] acinclude: Enable -Werror by default

Ilya Maximets i.maximets at ovn.org
Mon Nov 29 22:31:59 UTC 2021


On 11/7/21 11:56, Eli Britstein via dev wrote:
> Following dpdk commits [1]-[3], it is now possible to compile with
> --enable-Werror. Change the default to on, with an option to disable
> using --disable-Werror.
> 
> Notes:
> 1. To compile against 21.11-rc1, need to apply [4] and [5] patches.
> 2. There are still sparse errors, due to dpdk issue. [6] fixes it.
> 
> [1] a3f8d0587188 ("net: avoid cast-align warning in VLAN insert function")
> [2] da0333c8790b ("mbuf: avoid cast-align warning in data offset macro")
> [3] 6de430b7079e ("eal/x86: avoid cast-align warning in memcpy functions")
> [4] https://patchwork.ozlabs.org/project/openvswitch/list/?series=268844
> [5] https://patchwork.ozlabs.org/project/openvswitch/list/?series=261231
> [6] https://patches.dpdk.org/project/dpdk/patch/20211028101428.15007-1-david.marchand@redhat.com/
> 
> Signed-off-by: Eli Britstein <elibr at nvidia.com>
> Reviewed-by: Gaetan Rivet <gaetanr at nvidia.com>
> ---
>  .ci/linux-build.sh | 1 -
>  .cirrus.yml        | 2 +-
>  acinclude.m4       | 4 ++--
>  3 files changed, 3 insertions(+), 4 deletions(-)

Hi, Eli.  I'm not sure if I understand the reason behind this patch.
But, in any case, I believe that it will break the Windows build, as
it currently produces a fair amount of warnings.

Best regards, Ilya Maximets.


More information about the dev mailing list