[ovs-dev] [PATCH v5 0/2] flow dumps containing igmp match cannot be restored

Ilya Maximets i.maximets at ovn.org
Tue Nov 30 00:29:25 UTC 2021


On 11/29/21 16:50, Salvatore Daniele wrote:
> On Mon, Nov 29, 2021 at 8:01 AM Ilya Maximets <i.maximets at ovn.org> wrote:
>>
>> On 11/4/21 20:54, Salvatore Daniele wrote:
>>> Hi Ilya,
>>>
>>> Per your feedback on v4, I accounted for igmp_type/code, both in the
>>> work-around in 1/2, and removing it from match.c entirely in 2/2.
>>>
>>> I was not sure the best way to proceed regarding the issue I had
>>> mentioned on v4 where ofputil_normalize_match__() fails to recognize
>>> 'igmp/ip,nw_proto=2' as an L3 protocol and normalizes igmp flows,
>>> removing igmp_type/code.
>>>
>>> However, I feel removing the fields as you suggested should solve the
>>> problem regardless.
>>>
>>> Curious to hear your thoughts at your convenience!
>>
>> Hi.  Thanks for v5 and sorry for it taking so long for me to reply.
>>
>> Patches LGTM at the first glance.  I'll run a couple of tests with
>> them and apply if everything will look fine.
> 
> Great, thank you Ilya!

I moved the NEWS entry to the correct place and applied the series.
The first patch also backported down to 2.13.  Thanks!

Best regards, Ilya Maximets.


More information about the dev mailing list