[ovs-dev] [PATCH] ovs-ctl: add --ovs-vswitchd-options and --ovsdb-server-options to usage()
David Marchand
david.marchand at redhat.com
Sun Oct 3 15:27:36 UTC 2021
On Fri, Sep 24, 2021 at 7:49 PM <remijouannet at gmail.com> wrote:
>
> From: Remi Jouannet <remi.jouannet at outscale.com>
- The patch is trivial, but still worth a little explanation: the
options were already present, but missing a description in usage().
- We can backport your fix, so I'd flag the original commit for info
for maintainers.
Fixes: fce20b8b73b1 ("ovs-ctl: Permit to specify additional options")
- The ovsrobot reported an issue wrt missing sob.
Don't forget to pass -s when committing your changes.
You can check this before submitting v2, by calling:
$ ./utilities/checkpatch.py -1
== Checking 02c4b2542f43 ("ovs-ctl: add --ovs-vswitchd-options and
--ovsdb-server-options to usage()") ==
ERROR: Author Remi Jouannet <remi.jouannet at outscale.com> needs to sign off.
>
> ---
> utilities/ovs-ctl.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in
> index 7180079..389e064 100644
> --- a/utilities/ovs-ctl.in
> +++ b/utilities/ovs-ctl.in
> @@ -431,6 +431,10 @@ Debugging options for "start", "restart" and "force-reload-kmod":
> --ovs-vswitchd-wrapper=WRAPPER
> run specified daemon under WRAPPER (either 'valgrind' or 'strace')
>
> +Additional options:
> + --ovs-vswitchd-options=OPTIONS additional options for ovs-vswitchd (example: '-vconsole:dbg -vfile:dbg')
> + --ovsdb-server-options=OPTIONS additional options for ovsdb-server (example: '-vconsole:dbg -vfile:dbg')
> +
> File location options:
> --db-file=FILE database file name (default: $DB_FILE)
> --db-sock=SOCKET JSON-RPC socket name (default: $DB_SOCK)
- Looking at this script usage(), for consistency, I would move those
two with the other "less important options" that concern start,
restart and force-reload-kmod.
What do you think of:
@@ -420,7 +420,9 @@ Less important options for "start", "restart" and
"force-reload-kmod":
--daemon-cwd=DIR set working dir for OVS daemons
(default: $DAEMON_CWD)
--no-force-corefiles do not force on core dumps for OVS daemons
--no-mlockall do not lock all of ovs-vswitchd into memory
+ --ovsdb-server-options=OPTIONS additional options for ovsdb-server
(example: '-vconsole:dbg -vfile:dbg')
--ovsdb-server-priority=NICE set ovsdb-server's niceness
(default: $OVSDB_SERVER_PRIORITY)
+ --ovs-vswitchd-options=OPTIONS additional options for ovs-vswitchd
(example: '-vconsole:dbg -vfile:dbg')
--ovs-vswitchd-priority=NICE set ovs-vswitchd's niceness
(default: $OVS_VSWITCHD_PRIORITY)
--no-full-hostname set short hostname instead of full hostname
--no-record-hostname do not attempt to determine/record system
--
David Marchand
More information about the dev
mailing list