[ovs-dev] [PATCH] dpif:Fix typo in function pointer name bond-add

Kevin Traynor ktraynor at redhat.com
Wed Oct 13 14:37:46 UTC 2021


Suggested title:
dpif: Fix function pointer check for bond_add.

On 12/10/2021 09:11, Somnath Chatterjee via dev wrote:
> There was wrong typo in function pointer check in
> dpif_bond_add() before calling bond_add()
> 

Fixes: 9df65060cf4c ("userspace: Avoid dp_hash recirculation for 
balance-tcp bond mode.")

> Signed-off-by: Somnath Chatterjee <somnath.b.chatterjee at ericsson.com>

Patch looks good, maybe you can respin the commit title/msg to save 
maintainer doing it.

Acked-by: Kevin Traynor <ktraynor at redhat.com>

> ---
>   lib/dpif.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/dpif.c b/lib/dpif.c
> index 8c4aed4..294b1c4 100644
> --- a/lib/dpif.c
> +++ b/lib/dpif.c
> @@ -2012,7 +2012,7 @@ dpif_meter_del(struct dpif *dpif, ofproto_meter_id meter_id,
>   int
>   dpif_bond_add(struct dpif *dpif, uint32_t bond_id, odp_port_t *member_map)
>   {
> -    return dpif->dpif_class->bond_del
> +    return dpif->dpif_class->bond_add
>              ? dpif->dpif_class->bond_add(dpif, bond_id, member_map)
>              : EOPNOTSUPP;
>   }
> 



More information about the dev mailing list