[ovs-dev] [PATCH ovn] controller: do not mark bfd and ipv6_pd msgs as local-only

Mark Michelson mmichels at redhat.com
Fri Oct 15 19:00:08 UTC 2021

On 10/11/21 6:14 AM, Dumitru Ceara wrote:
> On 10/11/21 12:01 PM, Lorenzo Bianconi wrote:
>>> On 10/9/21 1:05 AM, Ihar Hrachyshka wrote:
>>>> This is correct, thank you for fixing it.
>>>> One comment and one question:
>>>> 1) While the referred patch that suppressed LOCAL_ONLY traffic exposed
>>>> the issue, it was always a bug, though affecting a tiny minority of
>>>> scenarios.
>>>> For example for PD, one can probably imagine a scenario where PD server
>>>> is not located in a provider network but is hosted on a VIF that is
>>>> attached to a "public" logical switch (no localnet ports!). This VIF may
>>>> be located on a different chassis, in which case, even without the
>>>> suppressing patch, PD requests wouldn't reach PD server. On the other
>>>> hand, they would reach the server if its VIF would happen to land on the
>>>> same chassis. A similar scenario may be envisioned for BFD, where router
>>>> ports are distributed across multiple chassis.
>>> I agree, the "Fixes" tag looks wrong.  I think it should be:
>>> Fixes: e3a398e9146e ("controller: Add ipv6 prefix delegation state machine")
>>> Fixes: 365a8a696afb ("bfd: support demand mode on rx side.")
>> ack, do I need to repost to fix them?
> I guess it's up to the maintainers; in any case if you plan to repost
> then feel free to include my ack:
> Acked-by: Dumitru Ceara <dceara at redhat.com>
> Regards,
> Dumitru

Thanks everyone, I updated the "Fixes" tags as suggested earlier in the 
thread and pushed the changes to main and branch-21.09.

> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

More information about the dev mailing list