[ovs-dev] [PATCH] ovsdb-server: add inactivity probe arg to ovsdb server

Seena Fallah seenafallah at gmail.com
Fri Oct 15 21:40:49 UTC 2021


Thanks for your notes. Well because I'm much comfortable with Github
features if it's okay I continue to push further changes in Github.

The reason I add this cmdline arg is creating dedicated remotes for each
ovsdb server seems only available with cmdline. For example, I want each
ovsdb server to listen on their host IP address and if I set it via
database it will apply on all DBs and so when I set to listen on x.x.x.x
just one host can listen on and others raise an error that they can't.
So I added this arg to help setting probe interval for those connections
that initialized with cmdline args and not stored in DB.

I'll add a unit test for it. For the documentation is it enough to add it
to `ovsdb-server --help` output or for example should I add it to the NEWS
file or...?

Thanks.

On Fri, Oct 15, 2021 at 10:50 PM Ilya Maximets <i.maximets at ovn.org> wrote:

> On 10/15/21 19:07, Michael Santana wrote:
> >
> >
> > On 10/14/21 8:45 PM, Seena Fallah wrote:
> >> Hi,
> >>
> >> I've made a patch in GitHub https://github.com/openvswitch/ovs/pull/371
> >> Please review it.
> > Hi Seena,
> >
> > We don't review pull request on github. The way to contribute is to send
> your patch to the mailing list.
>
> Well, that is not true.  Open vSwitch project does accept
> pull requests.  The chances for a patch to be reviewed in
> time are higher on a mail-list though, since it's still a
> main way to submit patches and only few people are actually
> getting notifications from github.
>
> Seena, I'll take a look at your patch on next week.  You
> may send it to the mail-list to hit a wider audience if
> you want.  At the first glance, I'd say that documentation
> updates and unit tests are missing in the patch.  Also,
> there is a way to configure these advanced parameters while
> adding remotes via the database, so I would like to know
> why this doesn't work for you and you need extra cmdline
> arguments?
>
> Best regards, Ilya Maximets.
>
> > Take a look at the other patches on the mailing list so you get an idea.
> To send your patch you must first generate the patch using `git
> format-patch`. Once the patch is generated you must then send it to the
> mailing list (best using `git send-email`)
> >
> > For more info please take a look at our contributing doc [1]
> >
> > If you have questions please dont hesitate to ask
> >
> > [1] -
> https://docs.openvswitch.org/en/latest/internals/contributing/submitting-patches/
> >>
> >> Thanks.
> >> _______________________________________________
> >> dev mailing list
> >> dev at openvswitch.org
> >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >>
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >
>
>


More information about the dev mailing list