[ovs-dev] [PATCH] bond: Fix return value check in bond_member_set_may_enable()

Yunjian Wang wangyunjian at huawei.com
Wed Sep 1 09:43:32 UTC 2021


The function bond_member_lookup() could return NULL, the return value
need to be checked.

Addresses-Coverity: ("Dereference null return value")
Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
---
 ofproto/bond.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/ofproto/bond.c b/ofproto/bond.c
index a4116588f..2dcfeda71 100644
--- a/ofproto/bond.c
+++ b/ofproto/bond.c
@@ -672,8 +672,13 @@ out:
 void
 bond_member_set_may_enable(struct bond *bond, void *member_, bool may_enable)
 {
+    struct bond_member *member;
+
     ovs_rwlock_wrlock(&rwlock);
-    bond_member_lookup(bond, member_)->may_enable = may_enable;
+    member = bond_member_lookup(bond, member_);
+    if (member) {
+        member->may_enable = may_enable;
+    }
     ovs_rwlock_unlock(&rwlock);
 }
 
-- 
2.18.1



More information about the dev mailing list