[ovs-dev] [PATCH ovn v3 1/2] ovn-northd: Rename ovn-northd.c to northd.c

0-day Robot robot at bytheb.org
Fri Sep 3 08:19:39 UTC 2021


Bleep bloop.  Greetings Mark Gray, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 117 characters long (recommended limit is 79)
#31 FILE: Documentation/tutorials/ovn-openstack.rst:780:
   0. ls_in_port_sec_l2 (northd.c:3234): inport == "ap" && eth.src == {fa:16:3e:a9:4c:c7}, priority 50, uuid 6dcc418a

WARNING: Line is 117 characters long (recommended limit is 79)
#40 FILE: Documentation/tutorials/ovn-openstack.rst:793:
   0. ls_in_port_sec_l2 (northd.c:3234): inport == "ap" && eth.src == {fa:16:3e:a9:4c:c7}, priority 50, uuid 6dcc418a

WARNING: Line is 93 characters long (recommended limit is 79)
#43 FILE: Documentation/tutorials/ovn-openstack.rst:795:
  13. ls_in_l2_lkup (northd.c:3529): eth.dst == fa:16:3e:99:7a:17, priority 50, uuid 57a4c46f

WARNING: Line is 119 characters long (recommended limit is 79)
#50 FILE: Documentation/tutorials/ovn-openstack.rst:801:
   8. ls_out_port_sec_l2 (northd.c:3654): outport == "bp" && eth.dst == {fa:16:3e:99:7a:17}, priority 50, uuid 8aa6426d

WARNING: Line is 117 characters long (recommended limit is 79)
#59 FILE: Documentation/tutorials/ovn-openstack.rst:1217:
   0. ls_in_port_sec_l2 (northd.c:3234): inport == "ap" && eth.src == {fa:16:3e:a9:4c:c7}, priority 50, uuid 6dcc418a

WARNING: Line is 140 characters long (recommended limit is 79)
#62 FILE: Documentation/tutorials/ovn-openstack.rst:1219:
   1. ls_in_port_sec_ip (northd.c:2364): inport == "ap" && eth.src == fa:16:3e:a9:4c:c7 && ip4.src == {10.1.1.5}, priority 90, uuid 343af48c

WARNING: Line is 83 characters long (recommended limit is 79)
#69 FILE: Documentation/tutorials/ovn-openstack.rst:1224:
   5. ls_in_pre_stateful (northd.c:2764): reg0[0] == 1, priority 100, uuid d1941634

WARNING: Line is 143 characters long (recommended limit is 79)
#75 FILE: Documentation/tutorials/ovn-openstack.rst:1229:
   6. ls_in_acl (northd.c:2925): !ct.new && ct.est && !ct.rpl && ct_label.blocked == 0 && (inport == "ap" && ip4), priority 2002, uuid a12b39f0

WARNING: Line is 93 characters long (recommended limit is 79)
#78 FILE: Documentation/tutorials/ovn-openstack.rst:1231:
  13. ls_in_l2_lkup (northd.c:3529): eth.dst == fa:16:3e:f6:e2:8f, priority 50, uuid c43ead31

WARNING: Line is 92 characters long (recommended limit is 79)
#85 FILE: Documentation/tutorials/ovn-openstack.rst:1237:
   1. ls_out_pre_acl (northd.c:2626): ip && outport == "17d870", priority 110, uuid 60395450

WARNING: Line is 89 characters long (recommended limit is 79)
#88 FILE: Documentation/tutorials/ovn-openstack.rst:1239:
   8. ls_out_port_sec_l2 (northd.c:3654): outport == "17d870", priority 50, uuid 91b5cab0

WARNING: Line is 121 characters long (recommended limit is 79)
#97 FILE: Documentation/tutorials/ovn-openstack.rst:1253:
   0. lr_in_admission (northd.c:4071): eth.dst == fa:16:3e:f6:e2:8f && inport == "lrp-17d870", priority 50, uuid fa5270b0

WARNING: Line is 90 characters long (recommended limit is 79)
#100 FILE: Documentation/tutorials/ovn-openstack.rst:1255:
   5. lr_in_ip_routing (northd.c:3782): ip4.dst == 10.1.2.0/24, priority 49, uuid 5f9d469f

WARNING: Line is 113 characters long (recommended limit is 79)
#109 FILE: Documentation/tutorials/ovn-openstack.rst:1263:
   6. lr_in_arp_resolve (northd.c:5088): outport == "lrp-82b983" && reg0 == 10.1.2.7, priority 100, uuid 03d506d3

WARNING: Line is 91 characters long (recommended limit is 79)
#119 FILE: Documentation/tutorials/ovn-openstack.rst:1271:
   3. lr_out_delivery (northd.c:5288): outport == "lrp-82b983", priority 100, uuid 00bea4f2

WARNING: Line is 87 characters long (recommended limit is 79)
#128 FILE: Documentation/tutorials/ovn-openstack.rst:1280:
   0. ls_in_port_sec_l2 (northd.c:3234): inport == "82b983", priority 50, uuid 9a789e06

WARNING: Line is 90 characters long (recommended limit is 79)
#131 FILE: Documentation/tutorials/ovn-openstack.rst:1282:
   3. ls_in_pre_acl (northd.c:2624): ip && inport == "82b983", priority 110, uuid ab52f21a

WARNING: Line is 93 characters long (recommended limit is 79)
#134 FILE: Documentation/tutorials/ovn-openstack.rst:1284:
  13. ls_in_l2_lkup (northd.c:3529): eth.dst == fa:16:3e:89:f2:36, priority 50, uuid dcafb3e9

WARNING: Line is 84 characters long (recommended limit is 79)
#145 FILE: Documentation/tutorials/ovn-openstack.rst:1293:
   2. ls_out_pre_stateful (northd.c:2766): reg0[0] == 1, priority 100, uuid 9e8e22c5

WARNING: Line is 204 characters long (recommended limit is 79)
#151 FILE: Documentation/tutorials/ovn-openstack.rst:1298:
   4. ls_out_acl (northd.c:2925): !ct.new && ct.est && !ct.rpl && ct_label.blocked == 0 && (outport == "cp" && ip4 && ip4.src == $as_ip4_0fc1b6cf_f925_49e6_8f00_6dd13beca9dc), priority 2002, uuid a746fa0d

WARNING: Line is 172 characters long (recommended limit is 79)
#154 FILE: Documentation/tutorials/ovn-openstack.rst:1300:
   7. ls_out_port_sec_ip (northd.c:2364): outport == "cp" && eth.dst == fa:16:3e:89:f2:36 && ip4.dst == {255.255.255.255, 224.0.0.0/4, 10.1.2.7}, priority 90, uuid 4d9862b5

WARNING: Line is 119 characters long (recommended limit is 79)
#157 FILE: Documentation/tutorials/ovn-openstack.rst:1302:
   8. ls_out_port_sec_l2 (northd.c:3654): outport == "cp" && eth.dst == {fa:16:3e:89:f2:36}, priority 50, uuid 0242cdc3

WARNING: Line is 95 characters long (recommended limit is 79)
#166 FILE: Documentation/tutorials/ovn-openstack.rst:1445:
   0. ls_in_port_sec_l2 (northd.c:3234): inport == "provnet-d1ac28", priority 50, uuid 8d86fb06

WARNING: Line is 92 characters long (recommended limit is 79)
#169 FILE: Documentation/tutorials/ovn-openstack.rst:1447:
  10. ls_in_arp_rsp (northd.c:3266): inport == "provnet-d1ac28", priority 100, uuid 21313eff

WARNING: Line is 133 characters long (recommended limit is 79)
#172 FILE: Documentation/tutorials/ovn-openstack.rst:1449:
  13. ls_in_l2_lkup (northd.c:3571): eth.dst == fa:16:3e:b2:d2:67 && is_chassis_resident("cr-lrp-ae9b52"), priority 50, uuid 7f28f51f

WARNING: Line is 89 characters long (recommended limit is 79)
#179 FILE: Documentation/tutorials/ovn-openstack.rst:1455:
   8. ls_out_port_sec_l2 (northd.c:3654): outport == "ae9b52", priority 50, uuid 72fea396

WARNING: Line is 161 characters long (recommended limit is 79)
#188 FILE: Documentation/tutorials/ovn-openstack.rst:1467:
   0. lr_in_admission (northd.c:4071): eth.dst == fa:16:3e:b2:d2:67 && inport == "lrp-ae9b52" && is_chassis_resident("cr-lrp-ae9b52"), priority 50, uuid 8c6945c2

WARNING: Line is 158 characters long (recommended limit is 79)
#191 FILE: Documentation/tutorials/ovn-openstack.rst:1469:
   3. lr_in_unsnat (northd.c:4591): ip && ip4.dst == 172.24.4.8 && inport == "lrp-ae9b52" && is_chassis_resident("cr-lrp-ae9b52"), priority 100, uuid e922f541

WARNING: Line is 156 characters long (recommended limit is 79)
#197 FILE: Documentation/tutorials/ovn-openstack.rst:1474:
   4. lr_in_dnat (northd.c:4649): ip && ip4.dst == 172.24.4.8 && inport == "lrp-ae9b52" && is_chassis_resident("cr-lrp-ae9b52"), priority 100, uuid 02f41b79

WARNING: Line is 90 characters long (recommended limit is 79)
#206 FILE: Documentation/tutorials/ovn-openstack.rst:1482:
   5. lr_in_ip_routing (northd.c:3782): ip4.dst == 10.0.0.0/26, priority 53, uuid 86e005b0

WARNING: Line is 113 characters long (recommended limit is 79)
#215 FILE: Documentation/tutorials/ovn-openstack.rst:1490:
   6. lr_in_arp_resolve (northd.c:5088): outport == "lrp-f264e7" && reg0 == 10.0.0.6, priority 100, uuid 2963d67c

WARNING: Line is 91 characters long (recommended limit is 79)
#225 FILE: Documentation/tutorials/ovn-openstack.rst:1498:
   3. lr_out_delivery (northd.c:5288): outport == "lrp-f264e7", priority 100, uuid 42dadc23

WARNING: Line is 87 characters long (recommended limit is 79)
#234 FILE: Documentation/tutorials/ovn-openstack.rst:1507:
   0. ls_in_port_sec_l2 (northd.c:3234): inport == "f264e7", priority 50, uuid 5b721214

WARNING: Line is 90 characters long (recommended limit is 79)
#237 FILE: Documentation/tutorials/ovn-openstack.rst:1509:
   3. ls_in_pre_acl (northd.c:2624): ip && inport == "f264e7", priority 110, uuid 5bdc3209

WARNING: Line is 93 characters long (recommended limit is 79)
#240 FILE: Documentation/tutorials/ovn-openstack.rst:1511:
  13. ls_in_l2_lkup (northd.c:3529): eth.dst == fa:16:3e:c1:f5:a2, priority 50, uuid 7957f80f

WARNING: Line is 84 characters long (recommended limit is 79)
#251 FILE: Documentation/tutorials/ovn-openstack.rst:1520:
   2. ls_out_pre_stateful (northd.c:2766): reg0[0] == 1, priority 100, uuid 247e02eb

WARNING: Line is 178 characters long (recommended limit is 79)
#257 FILE: Documentation/tutorials/ovn-openstack.rst:1525:
   4. ls_out_acl (northd.c:2925): !ct.new && ct.est && !ct.rpl && ct_label.blocked == 0 && (outport == "dp" && ip4 && ip4.src == 0.0.0.0/0 && icmp4), priority 2002, uuid b860fc9f

WARNING: Line is 172 characters long (recommended limit is 79)
#260 FILE: Documentation/tutorials/ovn-openstack.rst:1527:
   7. ls_out_port_sec_ip (northd.c:2364): outport == "dp" && eth.dst == fa:16:3e:c1:f5:a2 && ip4.dst == {255.255.255.255, 224.0.0.0/4, 10.0.0.6}, priority 90, uuid 15655a98

WARNING: Line is 119 characters long (recommended limit is 79)
#263 FILE: Documentation/tutorials/ovn-openstack.rst:1529:
   8. ls_out_port_sec_l2 (northd.c:3654): outport == "dp" && eth.dst == {fa:16:3e:c1:f5:a2}, priority 50, uuid 5916f94b

WARNING: Line is 117 characters long (recommended limit is 79)
#272 FILE: Documentation/tutorials/ovn-openstack.rst:1625:
   0. ls_in_port_sec_l2 (northd.c:3234): inport == "ap" && eth.src == {fa:16:3e:a9:4c:c7}, priority 50, uuid 6dcc418a

WARNING: Line is 166 characters long (recommended limit is 79)
#275 FILE: Documentation/tutorials/ovn-openstack.rst:1627:
   1. ls_in_port_sec_ip (northd.c:2390): inport == "ap" && eth.src == fa:16:3e:a9:4c:c7 && ip6.src == {fe80::f816:3eff:fea9:4cc7, fc11::5}, priority 90, uuid 604810ea

WARNING: Line is 83 characters long (recommended limit is 79)
#282 FILE: Documentation/tutorials/ovn-openstack.rst:1632:
   5. ls_in_pre_stateful (northd.c:2764): reg0[0] == 1, priority 100, uuid d1941634

WARNING: Line is 143 characters long (recommended limit is 79)
#288 FILE: Documentation/tutorials/ovn-openstack.rst:1637:
   6. ls_in_acl (northd.c:2925): !ct.new && ct.est && !ct.rpl && ct_label.blocked == 0 && (inport == "ap" && ip6), priority 2002, uuid 7fdd607e

WARNING: Line is 93 characters long (recommended limit is 79)
#291 FILE: Documentation/tutorials/ovn-openstack.rst:1639:
  13. ls_in_l2_lkup (northd.c:3529): eth.dst == fa:16:3e:ef:2f:8b, priority 50, uuid e1d87fc5

WARNING: Line is 92 characters long (recommended limit is 79)
#298 FILE: Documentation/tutorials/ovn-openstack.rst:1645:
   1. ls_out_pre_acl (northd.c:2626): ip && outport == "ad952e", priority 110, uuid 88f68988

WARNING: Line is 89 characters long (recommended limit is 79)
#301 FILE: Documentation/tutorials/ovn-openstack.rst:1647:
   8. ls_out_port_sec_l2 (northd.c:3654): outport == "ad952e", priority 50, uuid 5935755e

WARNING: Line is 121 characters long (recommended limit is 79)
#308 FILE: Documentation/tutorials/ovn-openstack.rst:1653:
   0. lr_in_admission (northd.c:4071): eth.dst == fa:16:3e:ef:2f:8b && inport == "lrp-ad952e", priority 50, uuid ddfeb712

WARNING: Line is 89 characters long (recommended limit is 79)
#311 FILE: Documentation/tutorials/ovn-openstack.rst:1655:
   5. lr_in_ip_routing (northd.c:3782): ip6.dst == fc22::/64, priority 129, uuid cc2130ec

WARNING: Line is 114 characters long (recommended limit is 79)
#320 FILE: Documentation/tutorials/ovn-openstack.rst:1663:
   6. lr_in_arp_resolve (northd.c:5122): outport == "lrp-1a8162" && xxreg0 == fc22::7, priority 100, uuid bcf75288

WARNING: Line is 91 characters long (recommended limit is 79)
#330 FILE: Documentation/tutorials/ovn-openstack.rst:1671:
   3. lr_out_delivery (northd.c:5288): outport == "lrp-1a8162", priority 100, uuid 5260dfc5

WARNING: Line is 87 characters long (recommended limit is 79)
#337 FILE: Documentation/tutorials/ovn-openstack.rst:1677:
   0. ls_in_port_sec_l2 (northd.c:3234): inport == "1a8162", priority 50, uuid 10957d1b

WARNING: Line is 90 characters long (recommended limit is 79)
#340 FILE: Documentation/tutorials/ovn-openstack.rst:1679:
   3. ls_in_pre_acl (northd.c:2624): ip && inport == "1a8162", priority 110, uuid a27ebd00

WARNING: Line is 93 characters long (recommended limit is 79)
#343 FILE: Documentation/tutorials/ovn-openstack.rst:1681:
  13. ls_in_l2_lkup (northd.c:3529): eth.dst == fa:16:3e:89:f2:36, priority 50, uuid dcafb3e9

WARNING: Line is 84 characters long (recommended limit is 79)
#354 FILE: Documentation/tutorials/ovn-openstack.rst:1690:
   2. ls_out_pre_stateful (northd.c:2766): reg0[0] == 1, priority 100, uuid 9e8e22c5

WARNING: Line is 204 characters long (recommended limit is 79)
#360 FILE: Documentation/tutorials/ovn-openstack.rst:1695:
   4. ls_out_acl (northd.c:2925): !ct.new && ct.est && !ct.rpl && ct_label.blocked == 0 && (outport == "cp" && ip6 && ip6.src == $as_ip6_0fc1b6cf_f925_49e6_8f00_6dd13beca9dc), priority 2002, uuid 12fc96f9

WARNING: Line is 178 characters long (recommended limit is 79)
#363 FILE: Documentation/tutorials/ovn-openstack.rst:1697:
   7. ls_out_port_sec_ip (northd.c:2390): outport == "cp" && eth.dst == fa:16:3e:89:f2:36 && ip6.dst == {fe80::f816:3eff:fe89:f236, ff00::/8, fc22::7}, priority 90, uuid c622596a

WARNING: Line is 119 characters long (recommended limit is 79)
#366 FILE: Documentation/tutorials/ovn-openstack.rst:1699:
   8. ls_out_port_sec_l2 (northd.c:3654): outport == "cp" && eth.dst == {fa:16:3e:89:f2:36}, priority 50, uuid 0242cdc3

WARNING: Line is 117 characters long (recommended limit is 79)
#375 FILE: Documentation/tutorials/ovn-openstack.rst:1885:
   0. ls_in_port_sec_l2 (northd.c:3234): inport == "ap" && eth.src == {fa:16:3e:a9:4c:c7}, priority 50, uuid 6dcc418a

WARNING: Line is 201 characters long (recommended limit is 79)
#378 FILE: Documentation/tutorials/ovn-openstack.rst:1887:
   1. ls_in_port_sec_ip (northd.c:2325): inport == "ap" && eth.src == fa:16:3e:a9:4c:c7 && ip4.src == 0.0.0.0 && ip4.dst == 255.255.255.255 && udp.src == 68 && udp.dst == 67, priority 90, uuid e46bed6f

WARNING: Line is 83 characters long (recommended limit is 79)
#385 FILE: Documentation/tutorials/ovn-openstack.rst:1892:
   5. ls_in_pre_stateful (northd.c:2764): reg0[0] == 1, priority 100, uuid d1941634

WARNING: Line is 229 characters long (recommended limit is 79)
#394 FILE: Documentation/tutorials/ovn-openstack.rst:1901:
   6. ls_in_acl (northd.c:2925): !ct.new && ct.est && !ct.rpl && ct_label.blocked == 0 && (inport == "ap" && ip4 && ip4.dst == {255.255.255.255, 10.1.1.0/24} && udp && udp.src == 68 && udp.dst == 67), priority 2002, uuid 9c90245d

WARNING: Line is 203 characters long (recommended limit is 79)
#397 FILE: Documentation/tutorials/ovn-openstack.rst:1903:
  11. ls_in_dhcp_options (northd.c:3409): inport == "ap" && eth.src == fa:16:3e:a9:4c:c7 && ip4.src == 0.0.0.0 && ip4.dst == 255.255.255.255 && udp.src == 68 && udp.dst == 67, priority 100, uuid 8d63f29c

WARNING: Line is 170 characters long (recommended limit is 79)
#402 FILE: Documentation/tutorials/ovn-openstack.rst:1907:
  12. ls_in_dhcp_response (northd.c:3438): inport == "ap" && eth.src == fa:16:3e:a9:4c:c7 && ip4 && udp.src == 68 && udp.dst == 67 && reg0[3], priority 100, uuid 995eeaa9

WARNING: Line is 84 characters long (recommended limit is 79)
#415 FILE: Documentation/tutorials/ovn-openstack.rst:1926:
   2. ls_out_pre_stateful (northd.c:2766): reg0[0] == 1, priority 100, uuid 0c066ea1

WARNING: Line is 176 characters long (recommended limit is 79)
#421 FILE: Documentation/tutorials/ovn-openstack.rst:1931:
   4. ls_out_acl (northd.c:3008): outport == "ap" && eth.src == fa:16:3e:bb:94:72 && ip4.src == 10.1.1.1 && udp && udp.src == 67 && udp.dst == 68, priority 34000, uuid 0b383e77

WARNING: Line is 172 characters long (recommended limit is 79)
#425 FILE: Documentation/tutorials/ovn-openstack.rst:1934:
   7. ls_out_port_sec_ip (northd.c:2364): outport == "ap" && eth.dst == fa:16:3e:a9:4c:c7 && ip4.dst == {255.255.255.255, 224.0.0.0/4, 10.1.1.5}, priority 90, uuid 7b8cbcd5

WARNING: Line is 119 characters long (recommended limit is 79)
#428 FILE: Documentation/tutorials/ovn-openstack.rst:1936:
   8. ls_out_port_sec_l2 (northd.c:3654): outport == "ap" && eth.dst == {fa:16:3e:a9:4c:c7}, priority 50, uuid b874ece8

Lines checked: 517, Warnings: 67, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list