[ovs-dev] [PATCH ovn v4 2/7] northd: Split northd.c

0-day Robot robot at bytheb.org
Fri Sep 3 12:40:53 UTC 2021


Bleep bloop.  Greetings Mark Gray, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Improper whitespace around control block
#1697 FILE: northd/ovn-northd.c:378:
    SBREC_DHCP_OPTIONS_FOR_EACH_SAFE(opt_row, opt_row_next, ctx->ovnsb_idl) {

ERROR: Improper whitespace around control block
#1746 FILE: northd/ovn-northd.c:427:
    HMAP_FOR_EACH(opt, hmap_node, &dhcpv6_opts_to_add) {

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1766 FILE: northd/ovn-northd.c:447:
  --ovnnb-db=DATABASE       connect to ovn-nb database at DATABASE\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1768 FILE: northd/ovn-northd.c:449:
  --ovnsb-db=DATABASE       connect to ovn-sb database at DATABASE\n\

WARNING: Line lacks whitespace around operator
#1770 FILE: northd/ovn-northd.c:451:
  --dry-run                 start in paused state (do not commit db changes)\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1771 FILE: northd/ovn-northd.c:452:
  --unixctl=SOCKET          override default control socket name\n\

Lines checked: 2424, Warnings: 9, Errors: 2


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list