[ovs-dev] [ovn] bug: vtep port binding update doesn't trigger flows update

[Numan Siddique]

On Mon, Sep 6, 2021 at 4:08 AM Odintsov Vladislav <VlOdintsov at croc.ru> wrote:
>
> Hi Numan,
>
> I’ve tried your advice and this helped — new flow was installed right after vtep port_binding appeared.
> At first glance full recompute in case of appearing a new vtep port_binding can be an "okay" solution, 'cause vtep PBs don’t create/delete very often.
> Anyway, what information do you need to handle L-P properly for there ports? I can test a possible solution.

Hi Vladislav,

Can you please test this patch out
https://patchwork.ozlabs.org/project/ovn/patch/20210907171507.1617879-1-numans@ovn.org/
and see if it fixes the issue.  We can't completely handle the I-P for
the vtep lport changes unless we move the
code you pointed out from physical_run() to a separate function.

The earlier change which you tested out triggers a full recompute of
all the engine nodes.
Whereas the proposed patch now triggers a recompute of only the
pflow_output engine for any changes
to vtep lports.  I think this should be good enough to fix this issue.


Thanks
Numan

>
> Regards,
> Vladislav Odintsov
>
> On 4 Sep 2021, at 19:25, Numan Siddique <numans at ovn.org<mailto:numans at ovn.org>> wrote:
>
> On Fri, Sep 3, 2021 at 7:26 PM Odintsov Vladislav <VlOdintsov at croc.ru<mailto:VlOdintsov at croc.ru>> wrote:
>
> Hi,
>
> On master branch I found a regression that OF flows not get installed when a new port_binding type=vtep appeared in sbdb.
> I found there is a comment that ovn-controller doesn’t know, what changed:
> https://github.com/ovn-org/ovn/blob/922c45f/controller/binding.c#L2431-L2436
>
> Actually, this flow doesn't get installed:
> https://github.com/ovn-org/ovn/blob/922c45f74a006d8c0dde400b130915b08b90a1e3/controller/physical.c#L1687-L1689
>
> In this switch statement, can you please try setting  - handled =
> false;  so that a full recompute is triggered and see if this solves
> the problem ?
>
> I'm not sure what is going on.  Either we can fall back to full
> recompute for any port binding changes to vtep ports or handle the I-P
> properly
> for vtep port bindings.
>
> Thanks
> Numan
>
>
>
> With new L-P processing codebase I couldn’t quickly understand, where the problem can be.
> So, ovn-appctl -t ovn-controller recompute solves tha problem and flow gets installed. Looks like this problem is really in inc. processing.
> Please, help. Thanks.
>
> Regards,
> Vladislav Odintsov
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org<mailto:dev at openvswitch.org>
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev