[ovs-dev] [PATCH ovn v3 2/3] northd, utils: support for RouteTables in LRs

[0-day Robot]

Bleep bloop.  Greetings Vladislav Odintsov, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Inappropriate bracing around statement
#243 FILE: northd/northd.c:8878:
    else {

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1553 FILE: utilities/ovn-nbctl.c:332:
  lrp-set-options PORT KEY=VALUE [KEY=VALUE]...\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1564 FILE: utilities/ovn-nbctl.c:356:
  [--policy=POLICY]\n\

WARNING: Line lacks whitespace around operator
#1566 FILE: utilities/ovn-nbctl.c:358:
  [--ecmp-symmetric-reply]\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1567 FILE: utilities/ovn-nbctl.c:359:
  [--route-table=ROUTE_TABLE]\n\

WARNING: Line lacks whitespace around operator
#1568 FILE: utilities/ovn-nbctl.c:360:
  lr-route-add ROUTER PREFIX NEXTHOP [PORT]\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1571 FILE: utilities/ovn-nbctl.c:362:
  [--policy=POLICY]\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1572 FILE: utilities/ovn-nbctl.c:363:
  [--route-table=ROUTE_TABLE]\n\

WARNING: Line lacks whitespace around operator
#1573 FILE: utilities/ovn-nbctl.c:364:
  lr-route-del ROUTER [PREFIX [NEXTHOP [PORT]]]\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1575 FILE: utilities/ovn-nbctl.c:366:
  [--route-table=ROUTE_TABLE]\n\

WARNING: Line is 82 characters long (recommended limit is 79)
#1854 FILE: utilities/ovn-nbctl.c:7060:
      "--may-exist,--ecmp,--ecmp-symmetric-reply,--policy=,--route-table=,--bfd?",

Lines checked: 1868, Warnings: 20, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot