[ovs-discuss] [PATCH] datapath: Support jumbo frames in the datapath device

Justin Pettit jpettit at nicira.com
Mon Aug 3 20:10:44 UTC 2009


On Aug 3, 2009, at 11:25 AM, Ben Pfaff wrote:

> Oops, I noticed something else: the ports aren't necessarily
> contiguously numbered 0...dp->n_ports and this code will OOPS if
> they aren't.  You should probably iterate over &dp->port_list
> instead.


Good point.  How's this look?

-=-=-=-=-=-=-=-=-=-
     list_for_each_entry_rcu (p, &dp->port_list, node) {
         struct net_device *dev = p->dev;

         /* Skip any internal ports, since that's what we're tyring to
          * set. */
         if (is_dp_dev(dev))
             continue;

         if (!mtu || dev->mtu < mtu)
             mtu = dev->mtu;
     }
-=-=-=-=-=-=-=-=-=-

--Justin






More information about the discuss mailing list