[ovs-discuss] [NIC-20 06/11] datapath: Fix OOPS when dp_sysfs_add_if() fails.

Justin Pettit jpettit at nicira.com
Thu Aug 6 01:44:27 UTC 2009


On Aug 5, 2009, at 3:37 PM, Ben Pfaff wrote:

> diff --git a/datapath/datapath.h b/datapath/datapath.h
> index e778a70..63d92cb 100644
> --- a/datapath/datapath.h
> +++ b/datapath/datapath.h
> @@ -64,9 +64,7 @@ struct datapath {
>
> -#ifdef SUPPORT_SYSFS
> 	struct kobject ifobj;
> -#endif
>
> @@ -94,9 +92,7 @@ struct net_bridge_port {
>
> -#ifdef SUPPORT_SYSFS
> 	struct kobject kobj;
> -#endif

Won't these conditional compiles blow up if SUPPORT_SYSFS is not  
enabled?  The create_dp() and new_nbp() functions seem to expect them.

--Justin







More information about the discuss mailing list