[ovs-discuss] [NIC-19 00/10] Make "brctl show" display expected topology

Ben Pfaff blp at nicira.com
Fri Aug 7 17:40:17 UTC 2009


The Citrix QA scripts assume that "brctl show" will show a topology as
if the Linux bridge were still in use; that is, as if there were one
bridge per VLAN and as if bonds were network devices of their own
instead of separate devices.  However, as currently implemented "brctl
show" will display the datapath topology, i.e. all VLANs and bond
devices lumped together into a single datapath.  This series of
commits the problem, by moving the implementation of the ioctls that
brctl uses into userspace in ovs-brcompatd, putting the necessary
translation logic into ovs-brcompatd, and creating dummy network
devices for bonds.

Fixes bug NIC-19.

This series of commits is also necessary, but not sufficient, to allow
XenCenter to accurately show the link status and statistics of bridges
(bug #1363).

Ben Pfaff (10):
  datapath: Unexport functions only used in openvswitch_mod.
  svec: New convenience macro SVEC_FOR_EACH.
  brcompatd: Make parse_command() parse commands without dp arguments.
  brcompatd: Break send_reply() up into more functions for flexibility.
  brcompatd: Fix handle_fdb_query_cmd() return value on error.
  brcompatd: Factor code out of handle_fdb_query_cmd().
  brcompat: Move BRCTL_GET_BRIDGES, BRCTL_GET_PORT_LIST into userspace.
  vswitchd: Support creating fake bond device interfaces.
  brcompat: Remove requirement that that no datapaths exist at load
    time.
  brcompat: Remove no-longer-needed #includes.

 datapath/brcompat.c                                |  112 +++-----
 datapath/dp_dev.c                                  |    2 -
 include/openvswitch/brcompat-netlink.h             |    7 +-
 lib/svec.h                                         |    9 +
 vswitchd/bridge.c                                  |   27 ++-
 vswitchd/ovs-brcompatd.c                           |  275 ++++++++++++++++----
 .../opt_xensource_libexec_interface-reconfigure    |    1 +
 7 files changed, 303 insertions(+), 130 deletions(-)





More information about the discuss mailing list