[ovs-discuss] [PATCH] dpif: Only clear 'all_dps' argument in dp_enumerate().

Ben Pfaff blp at nicira.com
Fri Aug 7 18:21:32 UTC 2009


Justin Pettit <jpettit at nicira.com> writes:

> Originally, the function dp_enumerate() initialized the 'all_dps'
> argument.  This is inconsistent with most other functions that take an
> svec argument, which would only clear the contents.  Further, if someone
> were not careful when reusing the svec, it could lead to memory leaks.
> With this change, the caller is expected to first call svec_init() on
> the argument.

Looks fine.




More information about the discuss mailing list