[ovs-discuss] [PATCH] xenserver: Bring up physical devices before configuring local port.

[Ben Pfaff]

Thanks, I pushed it out.

Justin Pettit <jpettit at nicira.com> writes:

> Seems reasonable to me.
>
> --Justin
>
>
> On Aug 7, 2009, at 5:02 PM, Ben Pfaff wrote:
>
>> If DHCP is in use, then the physical devices have to be up before we
>> configure the local port, otherwise the DHCP request will never hit
>> the
>> wire and we have no hope of getting an IP address.
>>
>> This problem has been here for a long time, but it was masked until
>> commit c170afc1 "xenserver: Really take devices down in
>> interface-reconfigure." actually caused devices to go down and stay
>> down.
>>
>> Fixes bug #1809 "vswitch upgrade broke the xenserver".
>> ---
>> .../opt_xensource_libexec_interface-reconfigure    |    6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/xenserver/opt_xensource_libexec_interface-reconfigure
>> b/
>> xenserver/opt_xensource_libexec_interface-reconfigure
>> index 67911f7..1b9f9e6 100755
>> --- a/xenserver/opt_xensource_libexec_interface-reconfigure
>> +++ b/xenserver/opt_xensource_libexec_interface-reconfigure
>> @@ -1015,9 +1015,6 @@ def action_up(pif):
>>         argv += configure_bond(bond_master)
>>     modify_config(argv)
>>
>> -    # Configure network devices.
>> -    configure_netdev(pif)
>> -
>>     # Bring up VLAN slave, plus physical devices other than bond
>>     # slaves (which we brought up earlier).
>>     if vlan_slave:
>> @@ -1025,6 +1022,9 @@ def action_up(pif):
>>     for physdev in set(physdevs) - set(bond_slave_physdevs):
>>         up_netdev(physdev)
>>
>> +    # Configure network devices.
>> +    configure_netdev(pif)
>> +
>>     # Update /etc/issue (which contains the IP address of the
>> management interface)
>>     os.system("/sbin/update-issue")
>>
>> --
>> 1.6.3.3
>>
>>
>> _______________________________________________
>> discuss mailing list
>> discuss at openvswitch.org
>> http://openvswitch.org/mailman/listinfo/discuss_openvswitch.org