[ovs-discuss] [nic19-2 1/5] datapath: Improve comments.
Ben Pfaff
blp at nicira.com
Tue Aug 18 23:08:27 UTC 2009
---
datapath/datapath.c | 4 ++--
datapath/dp_sysfs_dp.c | 5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/datapath/datapath.c b/datapath/datapath.c
index bf8043b..f506324 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -223,8 +223,8 @@ static int create_dp(int dp_idx, const char __user *devnamep)
init_waitqueue_head(&dp->waitqueue);
/* Initialize kobject for bridge. This will be added as
- * /sys/class/net/<devname>/bridge later, if sysfs is enabled. */
- kobject_set_name(&dp->ifobj, SYSFS_BRIDGE_PORT_SUBDIR); /* "bridge" */
+ * /sys/class/net/<devname>/brif later, if sysfs is enabled. */
+ kobject_set_name(&dp->ifobj, SYSFS_BRIDGE_PORT_SUBDIR); /* "brif" */
dp->ifobj.kset = NULL;
dp->ifobj.parent = NULL;
kobject_init(&dp->ifobj, &dp_ktype);
diff --git a/datapath/dp_sysfs_dp.c b/datapath/dp_sysfs_dp.c
index 9699a07..503f22e 100644
--- a/datapath/dp_sysfs_dp.c
+++ b/datapath/dp_sysfs_dp.c
@@ -460,7 +460,7 @@ static struct attribute *bridge_attrs[] = {
};
static struct attribute_group bridge_group = {
- .name = SYSFS_BRIDGE_ATTR,
+ .name = SYSFS_BRIDGE_ATTR, /* "bridge" */
.attrs = bridge_attrs,
};
@@ -479,6 +479,7 @@ int dp_sysfs_add_dp(struct datapath *dp)
struct kobject *kobj = to_kobj(dp->ports[ODPP_LOCAL]->dev);
int err;
+ /* Create /sys/class/net/<devname>/bridge directory. */
err = sysfs_create_group(kobj, &bridge_group);
if (err) {
pr_info("%s: can't create group %s/%s\n",
@@ -486,7 +487,7 @@ int dp_sysfs_add_dp(struct datapath *dp)
goto out1;
}
- /* Create /sys/class/net/<devname>/bridge directory. */
+ /* Create /sys/class/net/<devname>/brif directory. */
dp->ifobj.parent = kobj;
err = kobject_add(&dp->ifobj);
if (err) {
--
1.6.3.3
More information about the discuss
mailing list