[ovs-discuss] [PATCH] vswitchd: Fix bug in Ethernet address selection for bridge.

[Ben Pfaff]

Thank you, I pushed this out.

Justin Pettit <jpettit at nicira.com> writes:

> Looks good.
>
> --Justin
>
>
> On Aug 26, 2009, at 12:51 PM, Ben Pfaff wrote:
>
>> This bug was introduced in the merge from the citrix branch in commit
>> 8fef8c71 "Merge citrix into master."
>>
>> Thanks to Reid for characterizing the problem.
>>
>> Bug #1907.
>> ---
>> vswitchd/bridge.c |    1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
>> index 25df8d4..869d717 100644
>> --- a/vswitchd/bridge.c
>> +++ b/vswitchd/bridge.c
>> @@ -741,6 +741,7 @@ bridge_pick_local_hw_addr(struct bridge *br,
>> uint8_t ea[ETH_ADDR_LEN],
>>             !eth_addr_is_zero(iface_ea) &&
>>             memcmp(iface_ea, ea, ETH_ADDR_LEN) < 0)
>>         {
>> +            memcpy(ea, iface_ea, ETH_ADDR_LEN);
>>             *hw_addr_iface = iface;
>>         }
>>     }
>> --
>> 1.6.3.3
>>
>>
>> _______________________________________________
>> discuss mailing list
>> discuss at openvswitch.org
>> http://openvswitch.org/mailman/listinfo/discuss_openvswitch.org