[ovs-discuss] [PATCH] xenserver: Retrieve vSwitch version from binary in xsconsole

Justin Pettit jpettit at nicira.com
Tue Jul 28 22:33:18 UTC 2009


On Jul 28, 2009, at 3:02 PM, Ben Pfaff wrote:

> Isn't this just a long way of writing the following?

Yes, I shortened it as suggested.

> Also l and 1 look very similar, so l isn't a very good variable
> name.
>
> (I realize that there is a lot of very similar code in the same
> file.)

I changed it to "line" and updated the other places that did it, too.

I went ahead and pushed the commit after making these changes.

> Once we change this code, there is no longer any code in Open
> vSwitch or in NOX that uses the vSwitchVersion setting.  Does
> that mean that we can drop the code from %post and %postun in
> vswitch-xen.spec that sets it?  It tends to cause hangs on
> install and uninstall.

I think this is a good idea.

--Justin






More information about the discuss mailing list