[ovs-discuss] no-op range checks

YAMAMOTO Takashi yamamoto at valinux.co.jp
Wed Apr 13 03:37:28 UTC 2011


hi,

commit bb5bc6c042a22103612205483558f472f8929356
Author: Ben Pfaff <blp at nicira.com>
Date:   Mon Mar 21 14:30:33 2011 -0700

    lacp: Encapsulate configuration into new structs.

    This makes it easier to pass configuration between modules.

this commit made some range checks useless.
for example,

depbase=`echo vswitchd/bridge.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
        gcc -DHAVE_CONFIG_H -I.   -I ./include -I ./lib -I ./lib   -Wstrict-prototypes -Wall -Wno-sign-compare -Wpointer-arith -Wdeclaration-after-statement -Wformat-security -Wswitch-enum -Wunused-parameter -Wstrict-aliasing -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers  -g -O2 -MT vswitchd/bridge.o -MD -MP -MF $depbase.Tpo -c -o vswitchd/bridge.o vswitchd/bridge.c &&\
        mv -f $depbase.Tpo $depbase.Po
vswitchd/bridge.c: In function 'port_reconfigure_bond_lacp':
vswitchd/bridge.c:3034: warning: comparison is always false due to limited range of data type

% git rev-parse HEAD
a64e37a1d3990b9c2524d166119cb5564dc5d96c
% 

YAMAMOTO Takashi



More information about the discuss mailing list