[ovs-discuss] suspicious usage of fchmod

Ben Pfaff blp at nicira.com
Wed Apr 20 15:58:04 UTC 2011


On Tue, Apr 19, 2011 at 06:50:44PM -0700, Jesse Gross wrote:
> On Mon, Apr 18, 2011 at 11:25 AM, Ben Pfaff <blp at nicira.com> wrote:
> > With all that taken into account, here is a new version. ?On Linux, I
> > prefer the fchmod() based solution, because someday OVS may have to
> > add support for threads and the umask is not thread-local.
> 
> Doesn't this just introduce another portability problem?  If we do
> introduce threads then it will be less likely that we notice it since
> things will work fine on Linux.

We'll have to do extensive grepping around at that point anyway and
the system-specific #if should stand out well enough.



More information about the discuss mailing list