[ovs-discuss] suspicious usage of fchmod

[Jesse Gross]

On Thu, Apr 21, 2011 at 9:23 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Wed, Apr 20, 2011 at 02:55:10PM -0700, Jesse Gross wrote:
>> On Wed, Apr 20, 2011 at 8:58 AM, Ben Pfaff <blp at nicira.com> wrote:
>> > On Tue, Apr 19, 2011 at 06:50:44PM -0700, Jesse Gross wrote:
>> >> On Mon, Apr 18, 2011 at 11:25 AM, Ben Pfaff <blp at nicira.com> wrote:
>> >> > With all that taken into account, here is a new version. ?On Linux, I
>> >> > prefer the fchmod() based solution, because someday OVS may have to
>> >> > add support for threads and the umask is not thread-local.
>> >>
>> >> Doesn't this just introduce another portability problem? ?If we do
>> >> introduce threads then it will be less likely that we notice it since
>> >> things will work fine on Linux.
>> >
>> > We'll have to do extensive grepping around at that point anyway and
>> > the system-specific #if should stand out well enough.
>>
>> But what's the point of introducing this #ifdef in the first place?
>> It seems like there are two situations:
>> * We don't introduce threading, in which case there is no problem but
>> also no benefit from this extra piece of OS dependent code which will
>> rarely get exercised.
>> * We do implement threading, in which case there is a piece of code
>> which we will hopefully remember or find that needs to be fixed.
>
> It sounds like you'd prefer to use the portable solution everywhere.
> Fine.  Please review this:

That looks good to me, thanks.