[ovs-discuss] [PATCH] xenserver: Reduce number of xapi DB calls in plugin

Ben Pfaff blp at nicira.com
Wed Nov 30 16:27:08 UTC 2011


On Tue, Nov 29, 2011 at 05:51:57PM +0000, Dominic Curran wrote:
> From: Rob Hoes <rob.hoes at citrix.com>
> Subject: [PATCH] xenserver: Reduce number of xapi DB calls in plugin
> 
> When there are lots of PIFs in a XenServer/XCP pool, for example when
> there are many VLANs configured on the pool, operations such as
> PIF.get_all and loops over all PIFs which include database operations,
> are very inefficient when executed on a pool slave, and should be
> avoided as much as possible. This patch reduces the number of database
> calls in the update function of the openvswitch-cfg-update xapi plugin.
> 
> Signed-off-by: Rob Hoes <rob.hoes at citrix.com>
> Ack-by: Dominic Curran <Dominic.curran at citrix.com>

Your patch seems reasonable but it's wordwrapped and won't apply.  Can
you send it with a MUA that does not wrap lines?  "git send-email" is
the easiest way.

Other minor points: The correct tag is "Acked-by" (not "Ack-by") and the
correct mailing list for patches is dev at openvswitch.org.

Thanks,

Ben.



More information about the discuss mailing list