[ovs-discuss] [PATCH] lib/ofp-errors.h, lib/vconn.c, , lib/ofp-errors.c:: OFPERR_OFPBRC_BAD_VERSION generated from switch when there is version mismatch.

[Amit Tewari]

Hi Ben,
I will test the patch on master version.

I followed the 'CodingStyle' document available with openvswitch-1.6.1 tar for coding guidelines.
Please let me know what guidelines are not followed in vconn.c so that I can fix that.


Regards
Amit Tewari
NEC-HCL ST
 

-----Original Message-----
From: Ben Pfaff [mailto:blp at nicira.com] 
Sent: Friday, July 27, 2012 10:31 PM
To: Amit Tewari
Cc: 'discuss at openvswitch.org'; 'bugs at openvswitch.org'
Subject: Re: [PATCH] lib/ofp-errors.h, lib/vconn.c,, lib/ofp-errors.c:: OFPERR_OFPBRC_BAD_VERSION generated from switch when there is version mismatch.

On Fri, Jul 27, 2012 at 12:05:07PM +0000, Amit Tewari wrote:
> I am resending patch for generating OFPERR_OFPBRC_BAD_VERSION error
> in case of version mismatch in openflow packets from controller to
> switch. This patch is for latest release 1.6.1.

We only accept patches for "master".

The changes to vconn.c don't follow the coding style at all.



DISCLAIMER:

-----------------------------------------------------------------------------------------------------------------------

The contents of this e-mail and any attachment(s) are confidential and
intended

for the named recipient(s) only. 

It shall not attach any liability on the originator or NECHCL or its

affiliates. Any views or opinions presented in 

this email are solely those of the author and may not necessarily reflect the

opinions of NECHCL or its affiliates. 

Any form of reproduction, dissemination, copying, disclosure, modification,

distribution and / or publication of 

this message without the prior written consent of the author of this e-mail is

strictly prohibited. If you have 

received this email in error please delete it and notify the sender

immediately. .

-----------------------------------------------------------------------------------------------------------------------