[ovs-discuss] OpenVSwitch - "OFPBRC_BAD_VERSION" error packet not received when there is version mismatch between stats request and stats reply

Ben Pfaff blp at nicira.com
Tue May 22 18:09:34 UTC 2012


Can you provide a patch?  I'll apply it, if it's reasonable.

On Tue, May 22, 2012 at 07:40:49AM +0000, Varun Gupta wrote:
> The two issues I raised (stats request/reply and feature request/reply) were found when we were evaluating the switch's response in case the controller behave indifferently. 
> Our objective is to make OVS more robust and respond with an error (OFPBRC_BAD_VERSION)  in the cases of 'OFPET_BAD_REQUEST' error type as mentioned in spec (1.0):
> 
> -------------------------------------------
> 
> For the OFPET_BAD_REQUEST error type, the following codes are currently de-
> fined:
> /* ofp_error_msg 'code' values for OFPET_BAD_REQUEST. 'data' contains at least
> * the first 64 bytes of the failed request. */
> enum ofp_bad_request_code {
> OFPBRC_BAD_VERSION, /* ofp_header.version not supported. */
> ----------
> ----------
> };
> 
> ------------------------------------------
> 
> Regards,
> Varun
> 
> -----Original Message-----
> From: Ben Pfaff [mailto:blp at nicira.com] 
> Sent: Monday, May 21, 2012 10:04 PM
> To: Varun Gupta
> Cc: bugs at openvswitch.org
> Subject: Re: [ovs-discuss] OpenVSwitch - "OFPBRC_BAD_VERSION" error packet not received when there is version mismatch between stats request and stats reply
> 
> On Mon, May 21, 2012 at 10:50:19AM +0000, Varun Gupta wrote:
> > Switch is not notifying the controller for OFPBRC_BAD_VERSION, /*
> > ofp_header.version not supported. */ when there is version mismatch
> > between stats request and stats reply. The switch was resetting the
> > connection and only a warning message was generated on switch in log
> > (/var/log/messages) before resetting connection.
> 
> It's hard for me to consider this a serious bug, because it's a bug
> in the controller to send an OpenFlow message of a version that was
> not negotiated in the OpenFlow version negotiation.  I don't know why
> you'd do that.
> 
> 
> 
> DISCLAIMER:
> 
> -----------------------------------------------------------------------------------------------------------------------
> 
> The contents of this e-mail and any attachment(s) are confidential and
> intended
> 
> for the named recipient(s) only. 
> 
> It shall not attach any liability on the originator or NECHCL or its
> 
> affiliates. Any views or opinions presented in 
> 
> this email are solely those of the author and may not necessarily reflect the
> 
> opinions of NECHCL or its affiliates. 
> 
> Any form of reproduction, dissemination, copying, disclosure, modification,
> 
> distribution and / or publication of 
> 
> this message without the prior written consent of the author of this e-mail is
> 
> strictly prohibited. If you have 
> 
> received this email in error please delete it and notify the sender
> 
> immediately. .
> 
> -----------------------------------------------------------------------------------------------------------------------



More information about the discuss mailing list