[ovs-discuss] vlan-splinters drop all system vlan interfaces

[Alex Wang]

Hey Ben,

The bug is that "netdev_get_in4()" and "netdev_get_in6" return 0 when there
is ip address.

Fix is here:
"""
                 if (!netdev_open(vlan_dev->name, "system", &netdev)) {
                     if (!netdev_get_in4(netdev, NULL, NULL) ||
                         !netdev_get_in6(netdev, NULL)) {
-                        vlandev_del(vlan_dev->name);
-                    } else {
                         /* It has an IP address configured, so we don't own
                          * it.  Don't delete it. */
+                    } else {
+                        vlandev_del(vlan_dev->name);
                     }
                     netdev_close(netdev);
                 }
"""


On Mon, Jul 22, 2013 at 2:04 PM, Ben Pfaff <blp at nicira.com> wrote:

> You've already reported the bug.
>
> On Tue, Jul 23, 2013 at 12:54:04AM +0400, Roman Sokolkov wrote:
> > Ok, great. May be i could fill a bug?
> >
> > Thanks
> >
> >
> > 2013/7/22 Ben Pfaff <blp at nicira.com>
> >
> > > On Mon, Jul 22, 2013 at 05:18:39PM +0400, Roman Sokolkov wrote:
> > > > In source code i've found that it shouldn't remove vlan interfaces
> if it
> > > > has assigned IPv4 address, but this doesn't work. Correct if i am
> wrong
> > >
> > > If so, we'd happily take a patch to fix it, ideally including a test
> > > to guard against regression.
> > >
> >
> >
> >
> > --
> > Regards, Roman Sokolkov
> _______________________________________________
> discuss mailing list
> discuss at openvswitch.org
> http://openvswitch.org/mailman/listinfo/discuss
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openvswitch.org/pipermail/ovs-discuss/attachments/20130722/0827caec/attachment.html>