[ovs-discuss] mod_nw_tos: not a valid TOS

[Ben Pfaff]

On Fri, Mar 15, 2013 at 05:27:32AM -0700, Murphy McCauley wrote:
> On Mar 15, 2013, at 2:22 AM, NGUYEN Xuan Nam wrote:
> 
> > However I cannot insert a flow entry with mod_nw_tos:
> > 
> > root at namnx-HP-Z400-Workstation:/home/namnx# ovs-ofctl add-flow system at s1 priority=65535,idle_timeout=50000,dl_type=0x0800,nw_proto=17,in_port=1,actions=mod_nw_tos:10,output:2
> > ovs-ofctl: 10: not a valid TOS
> > root at namnx-HP-Z400-Workstation:/home/namnx# ovs-ofctl add-flow system at s1 priority=65535,idle_timeout=50000,dl_type=0x0800,nw_proto=17,in_port=1,actions=mod_nw_tos:2,output:2
> > ovs-ofctl: 2: not a valid TOS
> > root at namnx-HP-Z400-Workstation:/home/namnx# ovs-ofctl add-flow system at s1 priority=65535,idle_timeout=50000,dl_type=0x0800,nw_proto=17,in_port=1,actions=mod_nw_tos:3,output:2
> > ovs-ofctl: 3: not a valid TOS
> > 
> > 
> > In doc file, I see that ToS are between 0 and 255,.
> > What did I forget ?
> 
> 
> The ovs-ofctl man page does say that, but it also mentions that the
> bottom two bits are reserved.  The way it says it sort of makes it
> sound like they will be ignored (which I believe used to be the case),
> but it actually gives you the error you see.

Good point.  I sent out a patch that improves the description.