[ovs-discuss] Problem about ofp-util.c
Minoru TAKAHASHI
takahashi.minoru7 at gmail.com
Fri Jul 24 05:45:33 UTC 2015
Hi,
On 2015å¹´07æ22æ¥ 17:25, Minoru TAKAHASHI wrote:
> Hi,
>
> Thank you for reply.
>
> On 2015å¹´07æ22æ¥ 00:19, Ben Pfaff wrote:
>> On Tue, Jul 21, 2015 at 03:10:08PM +0900, Minoru TAKAHASHI wrote:
>>>> they do not make the corresponding change to the decoder
>>>
>>> Should I fix this problem?
>>> If so, please tell me that which source file should I fix.
>>> (Sorry, I am new in implementation of OpenvSwitch.)
>>
>> I cannot apply anything to the repository that makes tests fail, so yes
>> you should fix the decoder.
>>
>> The decode function is right next to the encode function.
> ## ------------------------------ ##
> ## openvswitch 2.4.90 test suite. ##
> ## ------------------------------ ##
>
> 694: ofproto - del group (OpenFlow 1.5) FAILED (ofproto.at:350)
> 696: ofproto - insert buckets FAILED (ofproto.at:424)
I think that the following code is causing the above error.
[lib/ofp-msgs.h]
https://github.com/openvswitch/ovs/blob/master/lib/ofp-msgs.h#L336
[tests/ofp-print.at]
https://github.com/openvswitch/ovs/blob/master/tests/ofp-print.at#L2003
After I fix these, the above error does not occur.
## ------------------------------ ##
## openvswitch 2.4.90 test suite. ##
## ------------------------------ ##
692: ofproto - no group support (OpenFlow 1.0) ok
693: ofproto - del group (OpenFlow 1.1) ok
694: ofproto - add indirect group ok
695: ofproto - del group (OpenFlow 1.5) ok
696: ofproto - del group deletes flows ok
Could you please take another look on the patches.
Thanks!
>>
>
> OK, I will try to make a patch.
> Please, wait a while.
>
> thanks,
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-openflow-Add-OpenFlow1.5-group-desc-request.patch
Type: text/x-patch
Size: 1105 bytes
Desc: not available
URL: <http://openvswitch.org/pipermail/discuss/attachments/20150724/b2b6bc4a/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ofp-util-Fix-group-desc-request-encoding.patch
Type: text/x-patch
Size: 2375 bytes
Desc: not available
URL: <http://openvswitch.org/pipermail/discuss/attachments/20150724/b2b6bc4a/attachment-0003.bin>
More information about the discuss
mailing list