[ovs-discuss] Problem about ofp-util.c

Minoru TAKAHASHI takahashi.minoru7 at gmail.com
Thu Jul 30 03:27:46 UTC 2015


Hi,

On 2015年07月28日 05:32, Ben Pfaff wrote:
> On Mon, Jul 27, 2015 at 05:01:26PM +0900, Minoru TAKAHASHI wrote:
>> On 2015年07月25日 00:34, Ben Pfaff wrote:
>>> On Fri, Jul 24, 2015 at 02:45:33PM +0900, Minoru TAKAHASHI wrote:
>>>> Hi,
>>>>
>>>> On 2015年07月22日 17:25, Minoru TAKAHASHI wrote:
>>>>> Hi,
>>>>>
>>>>> Thank you for reply.
>>>>>
>>>>> On 2015年07月22日 00:19, Ben Pfaff wrote:
>>>>>> On Tue, Jul 21, 2015 at 03:10:08PM +0900, Minoru TAKAHASHI wrote:
>>>>>>>> they do not make the corresponding change to the decoder
>>>>>>>
>>>>>>> Should I fix this problem?
>>>>>>> If so, please tell me that which source file should I fix.
>>>>>>> (Sorry, I am new in implementation of OpenvSwitch.)
>>>>>>
>>>>>> I cannot apply anything to the repository that makes tests fail, so yes
>>>>>> you should fix the decoder.
>>>>>>
>>>>>> The decode function is right next to the encode function.
>>>>
>>>>> ## ------------------------------ ##
>>>>> ## openvswitch 2.4.90 test suite. ##
>>>>> ## ------------------------------ ##
>>>>>
>>>>> 694: ofproto - del group (OpenFlow 1.5)              FAILED (ofproto.at:350)
>>>>> 696: ofproto - insert buckets                        FAILED (ofproto.at:424)
>>>>
>>>> I think that the following code is causing the above error.
>>>>
>>>> [lib/ofp-msgs.h]
>>>> https://github.com/openvswitch/ovs/blob/master/lib/ofp-msgs.h#L336
>>>>
>>>> [tests/ofp-print.at]
>>>> https://github.com/openvswitch/ovs/blob/master/tests/ofp-print.at#L2003
>>>>
>>>> After I fix these, the above error does not occur.
>>>
>>> Did you run all the tests?  I see three failures:
>>
>> Oh, sorry about that.
>> Hmm, how to run the testsuite is correct in the following?
>>
>> 1. uninstall ovs
>>
>>  sudo make uninstall
>>  sudo make distclean
>>
>> 2. install ovs
>>
>>  ./boot.sh
>>  ./configure
>>  make && sudo make install
>>
>> 3. run tests
>>
>>  ./tests/testsuite -C tests AUTOTEST_PATH=utilities:vswitchd:ovsdb:vtep:tests
> 
> You don't have to install (or uninstall) OVS to run the testsuite.  Just
> build OVS then run "make check".
> 

Thank you for your infomation!

I attached fixed patches in this email as follows.
In my environment, following patches did not cause the error when testsuite(make check) run.

* Fix group desc request encoding.
 - 0001-openflow-Add-OpenFlow1.5-group-desc-request.patch
 - 0002-ofp-util-Fix-group-desc-request-encoding.patch

* Fix port desc request encoding.
 - 0001-openflow-Add-OpenFlow1.5-port-desc-request.patch
 - 0002-ofp-util-Fix-port-desc-request-encoding.patch

thanks,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-openflow-Add-OpenFlow1.5-port-desc-request.patch
Type: text/x-patch
Size: 1010 bytes
Desc: not available
URL: <http://openvswitch.org/pipermail/discuss/attachments/20150730/97d4194a/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ofp-util-Fix-port-desc-request-encoding.patch
Type: text/x-patch
Size: 2504 bytes
Desc: not available
URL: <http://openvswitch.org/pipermail/discuss/attachments/20150730/97d4194a/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-openflow-Add-OpenFlow1.5-group-desc-request.patch
Type: text/x-patch
Size: 1105 bytes
Desc: not available
URL: <http://openvswitch.org/pipermail/discuss/attachments/20150730/97d4194a/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ofp-util-Fix-group-desc-request-encoding.patch
Type: text/x-patch
Size: 2414 bytes
Desc: not available
URL: <http://openvswitch.org/pipermail/discuss/attachments/20150730/97d4194a/attachment-0007.bin>


More information about the discuss mailing list