[ovs-discuss] No check for memory allocation from malloc()

Neil McKee neil.mckee at inmon.com
Tue Sep 15 19:33:03 UTC 2015

In OVS a callback fn is given to the sFlow library for all allocation,  but
the callback (ofproto/ofproto-dpif-sflow.c:sflow_agent_alloc_cb()) just
calls "calloc()" too.  This should probably be changed to xcalloc() as
defined in lib/util.c which does the right thing.   Thanks for pointing
this out.


Neil McKee
InMon Corp.

On Tue, Sep 15, 2015 at 12:13 PM, neeraj mehta <mehtaneeraj07 at gmail.com>

> Hi Team,
> I was looking a the code in sfow_agent.c file in sflAlloc( ) function.
> This funtion allocates memory via malloc but didn't check whether memory
> allocation is successful or not.
> I think there should be a check, in case malloc fails to allocate memory.
> Regards
> Neeraj
> _______________________________________________
> discuss mailing list
> discuss at openvswitch.org
> http://openvswitch.org/mailman/listinfo/discuss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openvswitch.org/pipermail/ovs-discuss/attachments/20150915/8945f8c5/attachment-0002.html>

More information about the discuss mailing list