[ovs-discuss] dpif inline documentation needs to be updated

Jesse Gross jesse at kernel.org
Thu Apr 7 21:42:01 UTC 2016


On Thu, Apr 7, 2016 at 2:22 PM, Zhang Qiang <dotslash.lu at gmail.com> wrote:
> Hi all,
>
> At lib/dpif.h line 117(as of git master d61fbed) the comment says:
>> Refer to OVS_KEY_ATTR_* and "struct ovs_key_*" in include/odp-netlink.h
>> for details.
>
> But the file include/odp-netlink.h doesn't exist any more. Quick searches
> with OVS_KEY_ATTR_ and ovs_key_ didn't indicate where odp-netlink.h was
> refactored to. Maybe the comment needs an update?

The authoritative source for these definitions is in
include/uapi/linux/openvswitch.h in the Linux kernel tree. There is
also a local copy in the OVS tree in
datapath/linux/compat/include/linux/openvswitch.h. Feel free to send a
patch to update the comments if they are out of date.



More information about the discuss mailing list