[ovs-discuss] Un-wildcarding dl_src in action NORMAL

[Ben Pfaff]

On Thu, Aug 18, 2016 at 03:56:13PM +0000, Mattia Citterio wrote:
> Hi all,
> 
> 
> We're an Italian telco and we use Openvswitch in our core routers. We use Openvswitch 2.4 but my question is also valid for the master branch.
> 
> Digging into the code we found a piece we're not able to understand:  https://github.com/openvswitch/ovs/blob/branch-2.4/ofproto/ofproto-dpif-xlate.c#L2221. Our question is: why do you un-wildcard (I mean set to 0xff) dl_src?
> 
> We think L2-switching is based only on dl_dst and the right instruction would be:
> 
> ​​memset(&wc->masks.dl_src, 0, sizeof wc->masks.dl_src);
> 
> Are we wrong?

The "normal" action does MAC learning, which looks at the source MAC.